Re: [whatwg/fetch] Partition HTTP Connections (#1063)

@MattMenke2 commented on this pull request.

Thanks, Shivani

> @@ -4531,12 +4536,15 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
     <var>httpRequest</var>'s
     <a for=request>credentials mode</a>.
 
-   <li><p>Set <var>httpCache</var> to the result of <a>determining the HTTP cache partition</a>,
+   <li><p>Set <var>httpStatePartition</var> to the result of <a>determining the HTTP state partition</a>,
    given <var>httpRequest</var>.
 
    <li><p>If <var>httpCache</var> is null, then set <var>httpRequest</var>'s

Thanks! Meant to put the line below this above it, but even that doesn't really handle the null case. Fixed.

> @@ -2071,15 +2071,16 @@ for each associated <a for="fetch group">fetch record</a> whose
 <a for=connection>connection pool</a> consists of zero or more
 <dfn lt=connection export id=concept-connection>connections</dfn>. Each
 <a>connection</a> is identified by an <b>origin</b> (an
-<a for=/>origin</a>) and <b>credentials</b> (a boolean).
+<a for=/>origin</a>), <b>credentials</b> (a boolean), and
+<b>httpStatePartition</b> (a <a for=/>site</a> list or null).

Done, everywhere (also "HTTP state partition" -> "HTTP state partition key")

> @@ -4796,7 +4804,7 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
 
  <li><p>Let <var>response</var> be null.
 
- <li><p>Let <var>httpCache</var> be the result of <a>determining the HTTP cache partition</a>, given
+ <li><p>Let <var>httpCache</var> be the result of <a>determining the HTTP state partition</a>, given

Thanks! Meant to put the line below this above it, but even that doesn't really handle the null case. Fixed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1063#pullrequestreview-460321817

Received on Monday, 3 August 2020 20:38:12 UTC