Re: [whatwg/fetch] Partition HTTP Connections (#1063)

@annevk commented on this pull request.

Thanks for taking this on Matt!

> @@ -2123,11 +2125,11 @@ clearly stipulates that <a>connections</a> are keyed on
      WebSocket saner -->
 
 
-<h3 id=http-cache-partitions>HTTP cache partitions</h3>
+<h3 id=http-state-partition>HTTP state partition key</h3>

Should we make this network or perhaps fetch partition key? Network might be better as we'll want to use it for things that do not go through Fetch as well, such as RTCDataChannel, right?

>     given <var>httpRequest</var>.
 
+   <li><p>Set <var>httpCache</var> to null.

How can it be non-null at this point?

> @@ -4796,8 +4806,8 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
 
  <li><p>Let <var>response</var> be null.
 
- <li><p>Let <var>httpCache</var> be the result of <a>determining the HTTP cache partition</a>, given
- <var>httpRequest</var>.
+ <li><p>Let <var>httpCache</var> be the result of <a>determining the HTTP state partition key</a>,
+ given <var>httpRequest</var>.

This returns a key, not a cache. I think that this illustrates that we still want an easy way to obtain a partitioned cache though and not inline that in various places.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1063#pullrequestreview-460742916