Re: [whatwg/streams] Rewrite to use Web IDL, and generally modernize (#1035)

@ricea commented on this pull request.

I've so far reviewed the preview up to the end of ReadableStream. It's very high quality. I haven't checked that all the links go to the right places. I think we might need to trust in Bikeshed for that.

>  
-  Note how we don't <code>await</code> the promise returned by {{WritableStreamDefaultWriter/write()}}; this would be
-  redundant with <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise. Additionally, similar to <a
-  href="#example-manual-write-batch">a previous example</a>, we use the <code>.catch(() => {})</code> pattern on the
-  promises returned by {{WritableStreamDefaultWriter/write()}}; in this case we'll be notified about any failures
-  <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise.
+(These are defined as internal methods, instead of as abstract operations, so that they can be
+called polymorphically by the {{Readab

Typo: note

>  
-  Note how we don't <code>await</code> the promise returned by {{WritableStreamDefaultWriter/write()}}; this would be
-  redundant with <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise. Additionally, similar to <a
-  href="#example-manual-write-batch">a previous example</a>, we use the <code>.catch(() => {})</code> pattern on the
-  promises returned by {{WritableStreamDefaultWriter/write()}}; in this case we'll be notified about any failures
-  <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise.
+(These are defined as internal methods, instead of as abstract operations, so that they can be
+called polymorphically by the {{Readab

`!` is not needed here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1035#pullrequestreview-396827679