- From: Adam Rice <notifications@github.com>
- Date: Tue, 21 Apr 2020 07:41:45 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 21 April 2020 14:41:59 UTC
@ricea commented on this pull request. > - Note how we don't <code>await</code> the promise returned by {{WritableStreamDefaultWriter/write()}}; this would be - redundant with <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise. Additionally, similar to <a - href="#example-manual-write-batch">a previous example</a>, we use the <code>.catch(() => {})</code> pattern on the - promises returned by {{WritableStreamDefaultWriter/write()}}; in this case we'll be notified about any failures - <code>await</code>ing the {{WritableStreamDefaultWriter/ready}} promise. +(These are defined as internal methods, instead of as abstract operations, so that they can be +called polymorphically by the {{Readab I don't know why Github attached this comment to totally the wrong line. I was referring to line 2131. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1035#discussion_r412245891
Received on Tuesday, 21 April 2020 14:41:59 UTC