- From: Darien Maillet Valentine <notifications@github.com>
- Date: Sun, 17 Nov 2019 11:53:05 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 17 November 2019 19:53:07 UTC
bathos commented on this pull request. > @@ -14555,6 +14682,11 @@ expression syntax [[!PERLRE]]) as follows: <td><code>=</code></td> <td><code class="regex"><span class="mute">/</span>-?(([0-9]+\.[0-9]*|[0-9]*\.[0-9]+)([Ee][+-]?[0-9]+)?|[0-9]+[Ee][+-]?[0-9]+)<span class="mute">/</span></code></td> </tr> + <tr> + <td id="prod-bigint"><emu-t class="regex">bigint</emu-t></td> + <td><code>=</code></td> + <td><code class="regex"><span class="mute">/</span>-?([1-9][0-9]*|0[Xx][0-9A-Fa-f]+|0[0-7]*)n<span class="mute">/</span></code></td> The combined lexical goal can currently be realized case insensitively (assuming one handles unnamed terminals in a lookup step). That will cease to be true after this change because this "n" is case sensitive. This isn’t a problem, but I’m mentioning it because it could plausibly impact existing Web IDL lexers if they’ve made certain assumptions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/525#pullrequestreview-318040099
Received on Sunday, 17 November 2019 19:53:07 UTC