- From: Darien Maillet Valentine <notifications@github.com>
- Date: Sun, 17 Nov 2019 11:47:26 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 17 November 2019 19:47:29 UTC
bathos commented on this pull request. > @@ -5768,6 +5807,7 @@ type. "boolean" "byte" "octet" + "bigint" The addition of this new unnamed terminal means the `Other` production needs to be updated to include that terminal here https://github.com/heycam/webidl/blob/c387fed823d2d4ccf8940bbc065f358ccf563073/index.bs#L6998-L6999 (Unnamed/quoted terminals ‘delete the token’ from the set of values represented by a named terminal, so _ident_ is currently inclusive of the string "bigint," but will cease to be, hence the need to explicitly add it to Other, which is inclusive of every terminal except for a few specific punctuation marks.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/525#pullrequestreview-318039813
Received on Sunday, 17 November 2019 19:47:29 UTC