Re: [heycam/webidl] Remove references to ECMAScript global environments (#681)

domenic approved this pull request.

LGTM with nits. Ctrl+Fing "environment" found a few more that would arguably be better as realms.

Soooo happy to see this update.

> @@ -6802,14 +6802,8 @@ that same global environment.
     </pre>
 </div>
 
-Unless otherwise specified, each ECMAScript global environment <dfn id="dfn-expose" for="ECMAScript global environment" export>exposes</dfn>
-all [=interfaces=]
-that the implementation supports.  If a given ECMAScript global environment does not
-expose an interface, then the requirements given in
-[[#es-interfaces]] are
-not followed for that interface.
-
-Note: This allows, for example, ECMAScript global environments for Web Workers to [=ECMAScript global environment/expose=]
+Note: All [=interfaces=] define which [=Realms=] they are [=exposed=] in.
+This allows, for example, [=Realms=] for Web Workers to [=expose=]

Good update.

> @@ -10956,10 +10950,8 @@ is the concatenation of the [=interface=]’s
     is called with property key |P|, the following steps are taken:
 
     1.  Let |A| be the [=interface=] for the [=named properties object=] |O|.
-    1.  Let |object| be the sole object from |O|’s ECMAScript global environment that [=implements=] |A|.
-
-        Note: For example, if the [=interface=] is the {{Window}} interface,
-        then the sole object will be this global environment’s window object.
+    1.  Let |object| be |O|.\[[Realm]]'s [=Realm/global object=].

You could also use O's relevant global object. But, your version is probably a bit better, as it stays closer to the IDL/ES level.

> @@ -12479,13 +12471,13 @@ the Realm given as an argument.
   [=interface=] that it [=implements=].
 </div>
 
-The global environment that a given [=platform object=]
-is associated with can <dfn id="dfn-change-global-environment" for="global environment" export>change</dfn> after it has been created.  When
-the global environment associated with a platform object is changed, its
+The [=Realm=] that a given [=platform object=]
+is associated with can <dfn id="dfn-change-global-environment" for="Realm" export>change</dfn> after it has been created.  When

Only in Gecko -_-. (Preexisting problem.)

> @@ -6769,24 +6769,24 @@ and comprise the following:
 *   <a href="#es-iterators">the function objects that correspond to iterators</a>
 *   [=map size getters=]
 
-Each [=Realm|ECMAScript global environment=]
+Each [=Realm=]
 must have its own unique set of each of
 the [=initial objects=], created
 before control enters any ECMAScript execution context associated with the
 environment, but after the global object for that environment is created.  The \[[Prototype]]s

```suggestion
Realm, but after the [=Realm/global object=] for that Realm is created.  The \[[Prototype]]s
```

> @@ -6802,14 +6802,8 @@ that same global environment.
     </pre>
 </div>
 
-Unless otherwise specified, each ECMAScript global environment <dfn id="dfn-expose" for="ECMAScript global environment" export>exposes</dfn>
-all [=interfaces=]
-that the implementation supports.  If a given ECMAScript global environment does not
-expose an interface, then the requirements given in
-[[#es-interfaces]] are
-not followed for that interface.
-
-Note: This allows, for example, ECMAScript global environments for Web Workers to [=ECMAScript global environment/expose=]
+Note: All [=interfaces=] define which [=Realms=] they are [=exposed=] in.
+This allows, for example, [=Realms=] for Web Workers to [=expose=]
 different sets of supported interfaces from those exposed in environments

```suggestion
different sets of supported interfaces from those exposed in Realms
```

> @@ -8804,7 +8798,7 @@ the [=named property getter=].
 
 The [{{Global}}] [=extended attribute=] must not
 be used on an [=interface=] that can have more
-than one object implementing it in the same ECMAScript global environment.
+than one object implementing it in the same [=Realm=].

Above this, [Global] says "it indicates that objects implementing this interface can be used as the global object in an ECMAScript environment". Probably "a Realm" or "an ECMAScript Realm".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/681#pullrequestreview-211924356