Re: [whatwg/streams] Add @@asyncIterator to ReadableStream (#980)

MattiasBuelens commented on this pull request.



> @@ -404,6 +406,9 @@ like
                 { preventClose, preventAbort, preventCancel, signal } = {})
     <a href="#rs-pipe-to">pipeTo</a>(dest, { preventClose, preventAbort, preventCancel, signal } = {})
     <a href="#rs-tee">tee</a>()
+
+    <a href="#rs-get-iterator">getIterator</a>({ preventCancel } = {})

What sort of order are we trying to maintain inside these class definitions?

For now, I've put them in the order as they appear in the spec text. If we're aiming for "constructor, properties, methods, symbols", then `getIterator` should go before `getReader`... but should we then also move the spec text for `getIterator` before that of `getReader`? 🤷‍♂️

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/980#pullrequestreview-197807031