- From: Mattias Buelens <notifications@github.com>
- Date: Tue, 29 Jan 2019 13:54:17 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 29 January 2019 21:54:38 UTC
MattiasBuelens commented on this pull request. > @@ -796,11 +797,11 @@ option. If <code><a for="underlying source">type</a></code> is set to <code>unde </code></pre> </div> -<h5 id="rs-asynciterator" method for="ReadableStream">getIterator({ <var>preventCancel</var> = false } = {})</h5> +<h5 id="rs-get-iterator" method for="ReadableStream">getIterator({ <var>preventCancel</var> } = {})</h5> I didn't like the `= false` inside the method signature, as that also ended up in the table of contents. `pipeTo` and `pipeThrough` don't specify any default values for individual properties either, so this is more consistent. 🙂 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/980#pullrequestreview-197803349
Received on Tuesday, 29 January 2019 21:54:38 UTC