Re: [heycam/webidl] Formalize the 'this' and 'given value' ambient values (#665)

domenic commented on this pull request.

This seems to be missing an actual definition for "this" and "given value". I think those would be helpful to have, to explain the concept. ("Every non-static operation, attribute getter, and attribute setter's algorithm steps have access to a \<dfn>this\</dfn>, ..." or something similar.)

There's also the typography question:

- Should we use bold?
- Should we encourage people to link to "this"'s dfn?

I don't feel strongly either way on those two questions.

> @@ -11244,8 +11244,9 @@ in which case they are exposed on every object that [=implements=] the interface
                 </dd>
             </dl>
 
-        1.  Perform the actions listed in the description of |attribute| that occur on setting, on
-            |object| if it is not null.
+        1.  Perform the actions listed in the description of |attribute| that occur on setting,
+            with |idlValue| as <b>given value</b> and

"the" given value sounds nicer to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/665#pullrequestreview-208660090

Received on Wednesday, 27 February 2019 17:31:01 UTC