- From: Dan Clark <notifications@github.com>
- Date: Wed, 27 Feb 2019 17:03:48 +0000 (UTC)
- To: w3c/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/webcomponents/pull/793/review/208646932@github.com>
dandclark commented on this pull request.
> - b\. If *url* is failure, then:
- i\. Let *error* be a new TypeError exception.
- - ii\. Set *htmlModule’s* *parse error* to *error*.
- - iii\. Return *htmlModule*. Note: This step is essentially validating all of the requested module specifiers. We treat a module with unresolvable module specifiers the same as one that cannot be parsed; in both cases, a syntactic issue makes it impossible to ever contemplate instantiating the module later.
- - 8\. Set *htmlModule’s* *record* to *result*.
- - 9\. Return *htmlModule*.
-- Define ParseHTMLModule(*source*, *realm*, *htmlModule*) as roughly the following. TODO Given that we define HTML Module Record in ES6, should this function be defined over there? We’re using the HTML5 parser though...
- - 1\. Let *record* be a new HTML Module record that this algorithm will subsequently initialize.
- - 2\. Run the HTML5 parser on source to obtain the result *document*.
- - 3\. Set *record*.[[HostDefined]] = *htmlModule*.
- - 4\. For each HTMLScriptElement *script* in *document*:
- - a\. Let *se* be a new ScriptEntry record (see definition in ES6 changes above).
+ - ii\. Set *htmlModuleScript*'s *parse error* to *error*.
+ - iii\. Return *htmlModuleScript*. Note: This step is essentially validating all of the requested module specifiers. We treat a module with unresolvable module specifiers the same as one that cannot be parsed; in both cases, a syntactic issue makes it impossible to ever contemplate instantiating the module later.
+ - 8\. Set *htmlModuleScript*'s *record* to *result*.
+ - 9\. Return *htmlModuleScript*.
+- Introduce a new algorithm ParseHTMLModule(*source*, *realm*, *htmlModuleScript*) as the following.
Yup, we moved it to https://github.com/w3c/webcomponents/issues/798.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/webcomponents/pull/793#discussion_r260848530
Received on Wednesday, 27 February 2019 17:04:13 UTC