[whatwg/streams] better-assert is broken (#985)

The `assert()` from `better-assert` isn't compatible with browserify and throws a TypeError when an assert fails.

```
    fs.readFileSync is not a function
    TypeError: fs.readFileSync is not a function
        at assert (eval at setup (/tmp/whatwg/streams/reference-implementation/run-web-platform-tests.js:40:14), <anonymous>:5163:16)
        at SetUpWritableStreamDefaultController (eval at setup (/tmp/whatwg/streams/reference-implementation/run-web-platform-tests.js:40:14), <anonymous>:3692:3)
        at SetUpWritableStreamDefaultControllerFromUnderlyingSink (eval at setup (/tmp/whatwg/streams/reference-implementation/run-web-platform-tests.js:40:14), <anonymous>:3721:3)
        at new WritableStream (eval at setup (/tmp/whatwg/streams/reference-implementation/run-web-platform-tests.js:40:14), <anonymous>:2956:5)
        at Test.promise_test (http://127.0.0.1:38453/streams/writable-streams/write.any.js:242:14)
        at Test.step (http://127.0.0.1:38453/resources/testharness.js:1561:25)
        at http://127.0.0.1:38453/resources/testharness.js:591:36
        at new Promise (<anonymous>)
        at http://127.0.0.1:38453/resources/testharness.js:590:20
        at process._tickCallback (internal/process/next_tick.js:68:7)
```

This has a couple of unfortunate effects:
1. Tests that expect a TypeError may pass when they should fail
2. rethrowAssertionErrorRejection doesn't recognise the exception as an assertion and so doesn't rethrow it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/985