Re: [w3c/screen-orientation] Editorial: Internal slots (#144)

marcoscaceres requested changes on this pull request.

Super close! Spotted a couple of things that need changing. 

> +          <tr>
+            <th>
+              Internal Slot
+            </th>
+            <th>
+              Description (non-normative)
+            </th>
+          </tr>
+        </thead>
+        <tbody>
+          <tr>
+            <td>
+              <a>[[\orientationLock]]</a>
+            </td>
+            <td>
+              A <a>document</a>'s <a>orientation lock</a> is represented by an

```suggestion
              The <a>[[\orientationLock]]</a> represents a <a>document</a>'s <a>orientation lock</a> as an
```

>        </h2>
+      <table>
+        <thead>
+          <tr>
+            <th>
+              Internal Slot
+            </th>
+            <th>
+              Description (non-normative)
+            </th>
+          </tr>
+        </thead>
+        <tbody>
+          <tr>
+            <td>
+              <a>[[\orientationLock]]</a>

```suggestion
              <dfn>[[\orientationLock]]</dfn>
```

>        </h2>
+      <table>
+        <thead>
+          <tr>
+            <th>
+              Internal Slot
+            </th>
+            <th>
+              Description (non-normative)

```suggestion
              Description
```

> @@ -646,25 +694,32 @@ <h2>
           <a><code>OrientationLockType</code></a> enum.
         </p>
         <p>
-          A <a>document</a>'s <dfn>orientation lock</dfn> is the orientation
-          lock that applies on its <a>top-level browsing context</a>. An
-          orientation lock is an unordered set of <a>OrientationType</a>.
+          The <dfn>[[\orientationLock]]</dfn> internal slot represents the

This is now defined in place above. 

>          </p>
       </section>
       <section>
         <h2>
           Default orientation
         </h2>
         <p>
-          A <a>document</a>'s <dfn>default orientation</dfn> is the set of
-          orientations to which the screen orientation is locked when it is not
-          explicitly locked by this API or any other means.
+          The <a>[[\defaultOrientation]]</a> internal slot represents the

This should only be said where [[\defaultOrientation]] is defined. 

>            orientation</a> is equivalent to unlocking because it means that it
-          no longer has a lock applied. However, it does not mean that the
-          <a>default orientation</a> has to be <a>any</a>.
+          no longer has a lock applied. However, this does not mean that the
+          <a>[[\defaultOrientation]]</a> has to be <a>any</a>.

remember, we said above that [[defaultOrientation]] is a set of values... so this should say something like "only contains the item "any"". 

You might need to check in the infra spec if sets contain items, values, or elements. I can't ever remember :(. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/144#pullrequestreview-199992797