Re: [w3c/screen-orientation] Editorial: Internal slots (#144)

marcoscaceres commented on this pull request.



> @@ -404,6 +403,58 @@ <h2>
         handler event type</a> is <code>"change"</code>.
       </p>
     </section>
+    <section>
+      <h2>
+        Extensions to the <a>document</a> interface
+      </h2>
+      <section>

```suggestion
      <p>
        This specification adds the following internal slots to the <a>Document</a> object. 
      </p>
      <section>
```

> +              <td>
+                <dfn>[[\defaultOrientation]]</dfn>
+              </td>
+              <td>
+                The set of orientations to which the screen orientation is
+                locked when not explicitly locked by this API or any other
+                means.
+              </td>
+            </tr>
+            <tr>
+              <td>
+                <dfn>[[\orientationPendingPromise]]</dfn>
+              </td>
+              <td>
+                Initially set to <code>null</code> this is a promise whose
+                associated operation is to lock the screen orientation.

Maybe: 
```HTML
Either <code>null</code> or a <a>promise</a>. When assigned a <a>Promise</a>, 
that promise represents a request to lock the screen to one of the supported orientations. 
The promise resolves after locking the orientation succeeds or rejects locking fails. 
```

> +              <th>
+                Internal Slot
+              </th>
+              <th>
+                Description (non-normative)
+              </th>
+            </tr>
+          </thead>
+          <tbody>
+            <tr>
+              <td>
+                <dfn>[[\orientationLock]]</dfn>
+              </td>
+              <td>
+                A <a>document</a>'s <a>orientation lock</a> is represented by
+                an unordered set of <a>orientationType</a>.

```suggestion
                an <a data-cite="infra#ordered-set">unordered set</a> of <a>orientationType</a>.
```

> @@ -646,25 +695,32 @@ <h2>
           <a><code>OrientationLockType</code></a> enum.
         </p>
         <p>
-          A <a>document</a>'s <dfn>orientation lock</dfn> is the orientation
-          lock that applies on its <a>top-level browsing context</a>. An
-          orientation lock is an unordered set of <a>OrientationType</a>.
+          The <a>[[\orientationLock]]</a> internal slot represents the

This should be where [[\orientationLock]] is defined, I think. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/144#pullrequestreview-198911552