Re: [w3c/manifest] Rewrite processing shortcuts algorithm to be more precise (#832)

dominickng commented on this pull request.



> +              <li>If <var>shortcut</var>["name"] or <var>shortcut</var>["url"]
+              are undefined, <a>issue a developer warning</a> and
+              <a>continue</a>.

We do check for empty strings where it makes sense, like the [Web Share Target spec](https://wicg.github.io/web-share-target/#share_target-member). I think it makes sense here.

We don't do it elsewhere because manifest properties are interpretable without `name`, so we don't want to invalidate the whole manifest when its `name` is empty. In this case, it's seems to be implied that if the `name` of a `ShortcutItem` is the empty string, it's invalid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/832#discussion_r354663305