[w3c/manifest] Rewrite processing shortcuts algorithm to be more precise (#832)

This change (choose one):

* [ ] Breaks existing normative behavior (please add label "breaking")
* [X] Adds new normative requirements
* [ ] Adds new normative recommendations or optional items
* [ ] Makes only editorial changes (only changes informative sections, or
  changes normative sections without changing behavior)
* [ ] Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

To my knowledge, no vendor has implemented this yet, so it is safe to change without getting commitment. This is a very small change to add some new error cases which result in the shortcut items being ignored.

Commit message:

Normative changes:

* shortcuts that meet certain failure conditions are ignored.
  * Checks that name and url are present, URL is valid and within scope of the manifest.

Other changes:

* Clarify that the ShortcutItem url member needs to be within scope.
* Rewrite processing shortcuts algorithm as an ordered list.
* Creates a new array and returns it, rather than discarding the result.
* Explicitly says where developer warnings should be issued.

Closes #831 
You can view, comment on, or merge this pull request online at:

  https://github.com/w3c/manifest/pull/832

-- Commit Summary --

  * Rewrite processing shortcuts algorithm as an ordered list.
  * Linkify concepts append and parse.
  * shortcuts algorithm: ignore a shortcut that fails certain tests.
  * Clarify that the ShortcutItem url member needs to be within scope.

-- File Changes --

    M index.html (54)

-- Patch Links --

https://github.com/w3c/manifest/pull/832.patch
https://github.com/w3c/manifest/pull/832.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/832