Re: [whatwg/fetch] strip request-body-header for redireting from POST to GET (#977)

annevk commented on this pull request.

This looks pretty good to me, modulo nits. Thanks for working on this!

@ricea do you have any further feedback? Should someone else from Chrome be consulted?

@youennf I'm not sure if WebKit does this at the moment, but your review would be appreciated. And we'll file a bug if there are any tests you might fail.

> @@ -4007,8 +4020,20 @@ optional <i>CORS-preflight flag</i>, run these steps:
    <var>request</var>'s <a for=request>method</a> is not `<code>HEAD</code>`
   </ul>
 
-  <p>then set <var>request</var>'s <a for=request>method</a> to `<code>GET</code>` and
-  <var>request</var>'s <a for=request>body</a> to null.
+  <p>then:
+
+  <ol class=brief>
+   <li><p> Set <var>request</var>'s <a for=request>method</a> to `<code>GET</code>` and
+   <var>request</var>'s <a for=request>body</a> to null.
+   <li><p> <p><a for="list">For each</a> <var>headerName</var> of

There's a markup error here.

> @@ -4007,8 +4020,20 @@ optional <i>CORS-preflight flag</i>, run these steps:
    <var>request</var>'s <a for=request>method</a> is not `<code>HEAD</code>`
   </ul>
 
-  <p>then set <var>request</var>'s <a for=request>method</a> to `<code>GET</code>` and
-  <var>request</var>'s <a for=request>body</a> to null.
+  <p>then:
+
+  <ol class=brief>
+   <li><p> Set <var>request</var>'s <a for=request>method</a> to `<code>GET</code>` and

No need for the space before "Set".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/977#pullrequestreview-326153335