Re: [whatwg/storage] Add UsageDetails dictionary (#69)

domenic commented on this pull request.



>  };
+
+dictionary StorageUsageDetails {
+    unsigned long long applicationCache;

Style: indentation is inconsistent with previous lines (appears to be two spaces)

> @@ -331,8 +341,13 @@ must run these steps:
 
    <li><p>Let <var>quota</var> be <a>site storage quota</a> for <var>origin</var>.
 
+   <li><p>Let <var>usageDetails</var> be a new {{StorageUsageDetails}} dictionary
+  whose members are the <a>site storage usage</a> for each <a>site storage backend</a>

Style: indentation is inconsistent with previous lines (got de-intended)

> @@ -178,6 +178,7 @@ larger <a>site storage quota</a>. Factors such as navigation frequency, recency
 bookmarking, and <a href="#persistence">permission</a> for {{"persistent-storage"}} can be used as
 indications of "popularity".
 
+A <dfn export>site storage backend</dfn> is a specific site storage implementation.

This doesn't really clarify anything. What is an implementation? Like, Chrome or Firefox or Safari? I think what you're getting at is what the spec refers to as "site".

> @@ -331,8 +341,13 @@ must run these steps:
 
    <li><p>Let <var>quota</var> be <a>site storage quota</a> for <var>origin</var>.
 
+   <li><p>Let <var>usageDetails</var> be a new {{StorageUsageDetails}} dictionary

The _quota_ is connected to this site storage unit. Should that concept be mentioned here, or is this type of usageDetails not related to the site storage unit?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/69#pullrequestreview-232419072