- From: jugglinmike <notifications@github.com>
- Date: Wed, 24 Apr 2019 09:27:15 -0700
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 24 April 2019 16:27:37 UTC
That highlights another misunderstanding in our prior discussion. When you wrote, > you're not changing all dispatch callers I interpreted this to mean > you're not changing all instances of 'fire a progress event' to use the **this** keyword Now I see that you meant, > you're not changing all instances of event dispatch to specify the target I've pushed up another commit to specify the target for the callers of "fire an event." I believe it is `this` in all cases. I'm more confident about this change because all events are "readystatechange", and the request upload object does not have a `readyState` attribute. Since this expands the scope of the patch, we'll need to update the commit message as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/246#issuecomment-486316829
Received on Wednesday, 24 April 2019 16:27:37 UTC