Re: [whatwg/encoding] Editorial: use IDL's this (#175)

domenic commented on this pull request.



> @@ -1701,6 +1706,7 @@ textReadable
 <p>The
 <dfn constructor for=TextEncoderStream id=dom-textencoderstream><code>TextEncoderStream()</code></dfn>
 constructor, when invoked, must run these steps:
+<!-- TODO: figure out constructors -->

So for example, this should get rid of the first and last step, and then do s/enc/this throughout.

> @@ -1332,6 +1335,7 @@ requires buffering of scalar values.
 
 <p>The <dfn constructor for=TextEncoder id=dom-textencoder><code>TextEncoder()</code></dfn>
 constructor, when invoked, must return a new {{TextEncoder}} object.
+<!-- TODO: what should this say in the new world? -->

Interesting. TextEncoder has no state so there's nothing to set up here. I guess this points to the fact that it really shouldn't be a class (it's just behavior, not data + behavior with individual instances having some meaning). But it is, presumably for symmetry, so here we are.

I guess "must do nothing"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/175#pullrequestreview-225763814