Re: [whatwg/encoding] Consider adding TextEncoder.containsLoneSurrogates() static (#174)

> With lookbehind support in JavaScript regular expressions, this functionality can trivially be implemented in userland

Sure, there's lots of ways to implement it (such as [this](https://github.com/rustwasm/wasm-bindgen/issues/1348#issuecomment-477357145)).

The reason for this suggestion was for performance, not functionality (because the browser can implement it faster).

The reason we cared about performance is because this function would be called a lot (every time a string is sent from JS to Rust).

However, we managed to narrow our use case down to only checking `<input>`, and after the `input` bug is fixed we won't need to check anything, so we no longer care much about the performance.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/issues/174#issuecomment-480792314

Received on Monday, 8 April 2019 11:25:37 UTC