- From: Ryosuke Niwa <notifications@github.com>
- Date: Tue, 11 Sep 2018 16:53:00 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 11 September 2018 23:53:22 UTC
rniwa commented on this pull request. > <li>If <var>node</var> is a {{Text}} node, run the <a>child text content change steps</a> for <var>parent</var>. - <li><p>If <var>parent</var>'s <a for=tree>root</a> is a <a for=/>shadow root</a>, and - <var>parent</var> is a <a>slot</a> whose <a for=slot>assigned nodes</a> is the empty list, - then run <a>signal a slot change</a> for <var>parent</var>. - - <li><p>Run <a>assign slotables for a tree</a> with <var>node</var>'s <a for=tree>root</a>. + <li><p>If the <i>suppress observers flag</i> is unset, then <a>update slots</a> with « », + <var>parent</var>, and « <var>node</var> ». Why do we need to run it on both `parent` and `node`? We just inserted `node` into the same tree as `parent`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/695#pullrequestreview-154440940
Received on Tuesday, 11 September 2018 23:53:22 UTC