- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 29 May 2018 14:24:08 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 29 May 2018 21:24:31 UTC
domenic approved this pull request. LGTM with nit I guess this technically doesn't close https://github.com/whatwg/url/issues/273 since that's about schemes, not URLs. Although that may be closeable anyway. > </ol> <li><p>Let <var>parsedURL</var> be the result of running the <a>basic URL parser</a> on <var>url</var> with <var>parsedBase</var>. - <li><p>If <var>parsedURL</var> is failure, <a>throw</a> a <code>TypeError</code> - exception. + <li><p>If <var>parsedURL</var> is failure, not <a>throw</a> a {{TypeError}}. Extra "not" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/388#pullrequestreview-124177689
Received on Tuesday, 29 May 2018 21:24:31 UTC