Re: [whatwg/fullscreen] Remove from top layer synchronously for not connected elements (#128)

foolip commented on this pull request.

I like this structure of a solution, having something funny happen when the fullscreen element is removed but not mucking with event timing or order in any other cases. Just some questions about the implications about the specifics.

> @@ -396,6 +396,15 @@ could be an open <{dialog}> element.
  <a>simple fullscreen document</a>, then set <var>doc</var> to <var>topLevelDoc</var> and
  <var>resize</var> to true.
 
+ <li><p>If <var>doc</var>'s <a>fullscreen element</a> is not connected:

Can you link to https://dom.spec.whatwg.org/#connected?

> @@ -396,6 +396,15 @@ could be an open <{dialog}> element.
  <a>simple fullscreen document</a>, then set <var>doc</var> to <var>topLevelDoc</var> and
  <var>resize</var> to true.
 
+ <li><p>If <var>doc</var>'s <a>fullscreen element</a> is not connected:
+  <ol>
+   <li><p><a for=set>Append</a> (<code>fullscreenchange</code>, <var>doc</var>'s

Exactly when this event will end up being fired won't be entirely reliable, it could be before or after the resize even depending on how fast the fullscreen transition is, but that's acceptable I think for this weird case. Did you look into firing the event in a task or microtask and which ways that is bad?

> @@ -396,6 +396,15 @@ could be an open <{dialog}> element.
  <a>simple fullscreen document</a>, then set <var>doc</var> to <var>topLevelDoc</var> and
  <var>resize</var> to true.
 
+ <li><p>If <var>doc</var>'s <a>fullscreen element</a> is not connected:
+  <ol>
+   <li><p><a for=set>Append</a> (<code>fullscreenchange</code>, <var>doc</var>'s
+   <a>fullscreen element</a>) to <var>doc</var>'s
+   <a>list of pending fullscreen events</a>.
+
+   <li><p><a lt="unfullscreen a document">Unfullscreen <var>doc</var></a>.

Do funny things happen if we don't do this step?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/128#pullrequestreview-122176515