- From: Matt Giuca <notifications@github.com>
- Date: Tue, 22 May 2018 00:44:56 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/issues/668/390894692@github.com>
I've put up a branch (but I can't make a PR until #670 lands; we should continue discussion on #669): https://github.com/mgiuca/manifest/compare/start-url-required...no-document-url This one is also a breaking change and may require some discussion. The break is that *before*, if the start URL did not match the document URL, the start URL (and likely scope) would be set to their default values, and manifest succeeds. Now, the entire manifest fails to load (in the "obtaining a manifest" steps). This is necessary in order to make the same-origin-as-document check not *intrinsic* to processing the manifest (allowing the manifest to be processed independent of the document), but rather make it just part of the process of loading a manifest from an HTML page. We can't really just alter the `start_url` and `scope` after the manifest is processed; then we're back to the manifest values being dependent on the document URL. I wonder what Chrome for Android does in this case (since the WebAPKs are built from the manifest, independent of the document URL, they clearly don't alter them to a default start_url if the origin doesn't match --- I wonder if they fail or if they simply allow a cross-origin PWA installation). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/issues/668#issuecomment-390894692
Received on Tuesday, 22 May 2018 07:45:19 UTC