Re: [whatwg/fullscreen] Adjust algorithm for FullyExitFullscreen. (#126)

foolip commented on this pull request.



>  </ol>
 
+<p>Whenever the <a>removing steps</a> run with a <var>removedNode</var>,

This will unconditionally run "fully exit fullscreen" when any node is removed. https://fullscreen.spec.whatwg.org/#removing-steps (here removed) will need to retain at least the bits up to "For each node in nodes" to only deal with elements "that have their fullscreen flag set".

>  
- <li><p><a lt="unfullscreen an element">Unfullscreen elements</a> whose <a>fullscreen flag</a> is
- set, within <var>document</var>'s <a>top layer</a>, except for <var>document</var>'s
- <a>fullscreen element</a>.
+ <li><p>If <var>topLevelDoc</var>'s <a>fullscreen element</a> is null, terminate these steps.

How should this interact with the changes in https://github.com/whatwg/fullscreen/pull/102? The "fullscreen element is null" condition should be impossible if top layer is modified *after* the synchronous part of this algorithm has run.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/126#pullrequestreview-121401900