Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

foolip commented on this pull request.



>  
  <li><p>Let <var>exitDocs</var> be the result of
  <a lt="collect documents to unfullscreen">collecting documents to unfullscreen</a> given
- <var>doc</var>.
+ <var>pendingDoc</var>.

> Would it make sense to add a step in the exit fullscreen that indicated if the fullscreen element is not connected then Unfullscreen it immediately (say after step 4)?

@dtapuska, was that assuming some of the changes in this PR, i.e., that within the "removing steps", we first call "exit fullscreen" (or "fully exit fullscreen") and then remove the element from top layer before any of the async bits, including resizing, happen? I'm not sure which step 4 you mean, but everything needs to be done or decided in the synchronous bits, as `document.fullscreenElement` will change by the end of the "removing steps".

(Probably this was clear, just restating to make sure.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#discussion_r189257732

Received on Friday, 18 May 2018 12:50:30 UTC