Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

dtapuska commented on this pull request.



>  
  <li><p>Let <var>exitDocs</var> be the result of
  <a lt="collect documents to unfullscreen">collecting documents to unfullscreen</a> given
- <var>doc</var>.
+ <var>pendingDoc</var>.

@upsuper I'm referring to the fact that you queue the `fullscreenchange` event before the viewport is resized asynchronously. The end page will see the `fullscreenchange` before the `resize` event. Whereas in Chrome at least the ordering is the `resize` event first then the `fullscreenchange` event (both sent at rAF time). But with your proposal you'll likely get
`fullscreenchange` in one rAF and a `resize` in another rAF.

So the second question is that you had proposed to change how when a node is removed from the document that you should dispatch unfullscreen the node, queue fullscreenchange events and resize the viewport. I'm indicating we should unfullscreen the node, resize the viewport then queue the fullscreenchange events. And to do this it would just be a twist on the `Exit fullscreen` algorithm so see if the fullscreen element (which is non-null) is connected. Again I'm new to this so I'm happy to take an answer that it doesn't make sense.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#discussion_r188624368