- From: Konstantin Simon Maria Möllers <notifications@github.com>
- Date: Wed, 02 May 2018 14:38:48 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 2 May 2018 21:39:10 UTC
Hi WHATWG team, I want to propose the following changes to example 8.9 in order to clarify it to the reader: - There was a closing brace missing which I've added. - The `url` variable is used out of nowhere; I would recommend to take the one coming from the `fetchEvent` which comes close to a real world scenario when using a ServiceWorker. - The example won't work in browsers as the response body is binary-encoded but the `LipFuzzTransformer` requires string chunks. Therefor, I would recommend adding a text decoding step before applying the former. Hence, the reader is able to try the example out in her/his browser. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/924 -- Commit Summary -- * Add missing brace in example 8.9 * Define a `url` constant for clarity in example 8.9 * Add a text decoding step to example 8.9 -- File Changes -- M index.bs (17) -- Patch Links -- https://github.com/whatwg/streams/pull/924.patch https://github.com/whatwg/streams/pull/924.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/924
Received on Wednesday, 2 May 2018 21:39:10 UTC