- From: Jungkee Song <notifications@github.com>
- Date: Tue, 19 Jun 2018 15:46:28 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 19 June 2018 22:46:50 UTC
@mattto, I left the above comment before I saw your last comment. > If one does waitUntil(skipWaiting()) in the install event handler, then skipWaiting() resolves immediately because Try Activate bails since waiting worker is null. You're right. I missed this point indeed. I'll review your PR. @jakearchibald, @wanderview, given @mattto's analysis, calling `skipWaiting()` in the install handlers wouldn't be an issue, right? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/issues/1187#issuecomment-398569800
Received on Tuesday, 19 June 2018 22:46:50 UTC