- From: Arthur Langereis <notifications@github.com>
- Date: Sun, 22 Jul 2018 05:47:30 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 22 July 2018 12:47:52 UTC
Hi, I'm adding these changes to my implementation and while the new test `piping/then-interception` now passes nicely, I'm getting test failures in many basic tests as they try to pass in objects created with `ReadableStreamCreateReadResult` as the `actual` param of `assert_object_equals`, which tries to call `actual.hasOwnProperty` which is not there. Easy to test by trying to run e.g. `readable-streams/cancel.html` but other tests in the readable-streams dir have failures as well. I realise the fix should be in the WPT repo but figured I report this here as this is the source of the failures. I just pulled from WPT so I either I'm doing something wrong or the tests are now broken. Ping @ricea -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/commit/a27a1fd0f8640d6054e0cbc8b6d7f5464dd096ab#commitcomment-29792350
Received on Sunday, 22 July 2018 12:47:52 UTC