- From: Reilly Grant <notifications@github.com>
- Date: Tue, 27 Feb 2018 14:00:13 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 27 February 2018 22:00:35 UTC
reillyeon commented on this pull request. > @@ -209,7 +209,7 @@ <h2><dfn>GamepadHapticActuator</dfn> Interface</h2> </p> <p> If the effect type is not compatible with the actuator, - <code>playEffect()</code> must immediately return a Promise resolved + the Promise returned by <code>playEffect()</code> must be resolved This still somewhat implies that when playEffect() returns the promise has already been resolved. To clarify this I would start above by saying, "It returns a new Promise `promise` and performs the following steps in parallel." Then below list out the available failure cases which all "resolve `promise` with..." and the final successful case which "resolves `promise` with `'complete'`." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/68#pullrequestreview-99872158
Received on Tuesday, 27 February 2018 22:00:35 UTC