- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 09 Feb 2018 15:11:10 +0000 (UTC)
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 9 February 2018 15:11:47 UTC
domenic approved this pull request. LGTM with naming nit. > @@ -1651,6 +1651,24 @@ them. For instance, if the operation has already completed. <li><p>[=Fire an event=] named <code>abort</code> at <var>signal</var>. </ol> +<p>A <var>followingSignal</var> (an {{AbortSignal}}) <dfn export for=AbortSignal>follows</dfn> a +<var>parentSignal</var> (an {{AbortSignal}}) by running these steps: Nit: I think I'd rather make the algorithm have a name that isn't an adjective, but instead a verb. E.g. "A followingSignal is made to follow a parentSignal by..." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/569#pullrequestreview-95450002
Received on Friday, 9 February 2018 15:11:47 UTC