- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 09 Feb 2018 15:08:52 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 9 February 2018 15:09:16 UTC
Changes LGTM, but can we also add tests for the various bad cases we're trying to fix here? In particular tests that the constructor throws, and maybe if it's possible to get down this code path via allocated-by-the-implementation BYOB requests, a test that allocated-by-the-implementation BYOB requests don't suffer the same failure modes. (The latter might already be tested though.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/870#issuecomment-364459784
Received on Friday, 9 February 2018 15:09:16 UTC