Re: [whatwg/fetch] "If signal is not null, then add the following a..." (#668)

The change proposed by ricea@ looks good. Just a subtle point. Maybe the step (i) is only modifying the aborted flag since we know that it's a just-made AbortSignal. Just as a principle, it's nice in terms of future-proofness to depend on a limited set of public interfaces, i.e. Signal abort. I kinda feel that it makes sense to have some helper to do chaining safely as ricea@ mentioned, in the spec.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/issues/668#issuecomment-364043770

Received on Thursday, 8 February 2018 08:54:39 UTC