Re: [w3c/permissions] Add support for permissions that have an associated Feature Policy (#163)

jyasskin approved this pull request.

The change looks good to me, with an update to match Feature Policy changes since you wrote it. I'm sorry for taking so long to look at this.

> @@ -44,6 +44,11 @@ spec: sensors; urlPrefix: https://w3c.github.io/sensors/#
 spec: manifest; urlPrefix: https://w3c.github.io/manifest/#
     type: dfn
         text: install; url: dfn-install
+spec: feature-policy; urlPrefix: https://wicg.github.io/feature-policy/#
+    type: dfn
+        text: policy-controlled feature
+    type: dfn
+        text: feature name

This reference doesn't exist in the Feature Policy spec anymore. Maybe use wording like in https://wicg.github.io/feature-policy/#parse-policy-directive:

> Let _feature_ be the [=policy-controlled feature=] identified by _feature-name_.

> @@ -44,6 +44,11 @@ spec: sensors; urlPrefix: https://w3c.github.io/sensors/#
 spec: manifest; urlPrefix: https://w3c.github.io/manifest/#
     type: dfn
         text: install; url: dfn-install
+spec: feature-policy; urlPrefix: https://wicg.github.io/feature-policy/#
+    type: dfn
+        text: policy-controlled feature

Feature Policy has gotten into Shepherd since you wrote this, so you can undo this addition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/163#pullrequestreview-108776734