Re: [w3c/manifest] Add IDL section and define IDL for all the members (#613)

mgiuca approved this pull request.

lgtm with some comments. Very nice work!

>        </p>
+      <pre class="idl">
+          [NoInterfaceObject]
+          dictionary WebAppManifest {
+             TextDirectionType? dir;
+             USVString? lang;

Conversely to what I said yesterday, I think "lang", "iarc_rating_id", and any other "id" or other ASCII-only fields could be DOMString instead of USVString. Practically, it probably doesn't really matter, but the WebIDL spec says "if in doubt, use DOMString".

>        </h2>
       <div class="issue" data-number="361"></div>
+      <pre class="idl">
+        [NoInterfaceObject]
+        dictionary ImageResource {
+          USVString src;

required?

>        </h2>
       <div class="issue" data-number="361"></div>
+      <pre class="idl">
+        [NoInterfaceObject]
+        dictionary ImageResource {
+          USVString src;
+          DOMString sizes;

required?

>          registration for the web application.
       </p>
-      <section>
+      <pre class="idl">
+        [NoInterfaceObject]
+        dictionary ServiceWorkerRegistration {
+          USVString src;

required?

>        </h2>
+      <pre class="idl">
+        [NoInterfaceObject]
+        dictionary ExternalApplicationResource {
+          USVString platform;

required

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/613#pullrequestreview-64174329