- From: Adam Rice <notifications@github.com>
- Date: Tue, 19 Sep 2017 07:50:51 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 19 September 2017 07:51:13 UTC
ReadableStreamDefaultControllerClose is defined in the standard as "nothrow" but TransformStreamCloseReadableInternal contains an assert that it doesn't throw. The assertion that it doesn't throw is already implied by the "nothrow" annotation. Since it is good to aim for a 1:1 relationship between the reference implementation and the standard text, the reference implementation shouldn't contain this assert either. Removed. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/801 -- Commit Summary -- * Remove assertion that RSDefaultControllerClose doesn't throw -- File Changes -- M reference-implementation/lib/transform-stream.js (6) -- Patch Links -- https://github.com/whatwg/streams/pull/801.patch https://github.com/whatwg/streams/pull/801.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/801
Received on Tuesday, 19 September 2017 07:51:13 UTC