Re: [whatwg/url] Fix Windows drive letter handling in the file slash state (#343)

rmisev commented on this pull request.



> @@ -1877,8 +1897,9 @@ string <var>input</var>, optionally with a <a>base URL</a> <var>base</var>, opti
 
       <ol>
        <li>
-        <p>If <var>base</var> is non-null and <var>base</var>'s <a for=url>scheme</a> is
-        "<code>file</code>", then:
+        <p>If <var>base</var> is non-null, <var>base</var>'s <a for=url>scheme</a> is
+        "<code>file</code>", and the substring from <var>pointer</var> in <var>input</var> does not
+        <a>start with a Windows drive letter</a>, then:

> What do we gain by removing reference to remaining?

The simpler check, that there are at least two code points:
- without remaining: `substr.length >= 2`
- with remaining: `c != EOF && remaining.length >= 1`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/343#discussion_r139360616