Re: [whatwg/fetch] Aborting fetch (#523)

annevk commented on this pull request.

@domenic did you want to do another pass?

> @@ -1311,6 +1327,10 @@ navigate algorithm. It ensures `<code>Location</code>` has
 <hr>
 
 <p>A <a for=/>response</a> whose
+<a for=response>type</a> is "<code>error</code>" and <a for=response>aborted flag</a> is set is
+known as a <dfn export id=concept-aborted-network-error>aborted network error</dfn>.

an*

>  
- <li><p>Add <var>connection</var> to the <a for=connection>connection pool</a>
- with <b>origin</b> being <var>origin</var> and <b>credentials</b> being <var>credentials</var>.
+ <li>
+  <p>If the ongoing fetch is <a for=fetch>terminated</a>, then:
+
+  <ol>
+   <li><p>If <var>connection</var> is not null, close <var>connection</var>.

then close*

> @@ -4695,6 +4861,7 @@ dictionary RequestInit {
   RequestRedirect redirect;
   DOMString integrity;
   boolean keepalive;
+  AbortSignal? signal;

Why is this nullable and the readonly attribute is not? What does null signify vs undefined?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/523#pullrequestreview-62736680