Re: [heycam/webidl] Various editorial updates related to ECMAScript (#436)

tobie approved this pull request.

Great stuff. A few nits.

Worth merging without squashing imho.

> @@ -5747,7 +5742,7 @@ The following extended attributes are <dfn for="extended attributes">applicable
 
 <div algorithm>
     The <dfn for="IDL type" lt="extended attribute associated with|extended attributes associated with">extended attributes associated with</dfn>
-    a [=type=] |type| are determined as follows:

Shouldn't we add a DFN for WebIDL types here, instead of removing the linking altogether?

>  \[[DefineOwnProperty]],
-\[[GetOwnProperty]], and
-\[[Delete]].
+\[[Set]],
+\[[Delete]],
+\[[OwnPropertyKeys]], and
+\[[Call]].

I'm wondering if we should get rid of the above list too. I'm not sure keeping it around adds any value.

> @@ -1223,7 +1219,7 @@ lie outside the valid range of values for its type, as given in
     1.  Let |S| be the sequence of characters matched by the
         <emu-t class="regex"><a href="#prod-float">float</a></emu-t> token.
     1.  Let |result| be the Mathematical Value that would be obtained if
-        |S| were parsed as an ECMAScript [=NumericLiteral=].
+        |S| were parsed as an ECMAScript <emu-nt>[=NumericLiteral=]</emu-nt>.

Have you checked that this doesn't create issues with the JS script that handles all of the grammar productions dynamically?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/436#pullrequestreview-61678506