Re: [heycam/webidl] Meta: Use OrdinarySetWithOwnDescriptor (#435)

annevk commented on this pull request.



> @@ -12086,8 +12086,7 @@ and [[#legacy-platform-object-set]].
             1.  [=Invoke the named property setter=] with |P| and |V|.
             1.  Return <emu-val>true</emu-val>.
     1.  Let |ownDesc| be <a abstract-op>LegacyPlatformObjectGetOwnProperty</a>(|O|, |P|, <emu-val>true</emu-val>).
-    1.  Perform [=?=] [=OrdinarySet=](|O|, |P|, |V|, |Receiver|) from step 3 onwards
-        with its internal "ownDesc" variable set to |ownDesc|.
+    1.  Perform [=?=] [=OrdinarySetWithOwnDescriptor=](|O|, |P|, |V|, |Receiver|, |ownDesc|).

`|V|` should be `<emu-val>true</emu-val>` I suspect? And it also looks like we don't have a `|Receiver|`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/435#pullrequestreview-61429841

Received on Friday, 8 September 2017 07:29:08 UTC