Re: [whatwg/streams] Remove TransformStream _readableClosed member (#782)

domenic requested changes on this pull request.

A number of somewhat-serious editorial issues, but the overall technical change and the tests are solid.

> @@ -840,6 +840,17 @@ readable stream is <a>locked to a reader</a>.
   1. Return *true*.
 </emu-alg>
 
+<h4 id="is-readable-stream-readable" aoid="IsReadableStreamReadable" nothrow>IsReadableStreamReadable (

This doesn't appear to be used in the spec, but only in the reference implementation.

Also, it's kind of a lame abstract operation? Is the idea just to preserve encapsulation in some way? Meh....

>  
 <emu-alg>
   1. If ! ReadableStreamDefaultControllerShouldCallPull(_controller_) is *true*, return *false*.
   1. Otherwise, return *true*.
 </emu-alg>
 
+<h4 id="readable-stream-default-controller-can-close-or-enqueue" aoid="ReadableStreamDefaultControllerCanCloseOrEnqueue"
+nothrow export>ReadableStreamDefaultControllerCanCloseOrEnqueue ( <var>controller</var> )</h4>

Probably don't want to export this one.

> @@ -316,6 +318,16 @@ function IsReadableStreamLocked(stream) {
   return true;
 }
 
+function IsReadableStreamReadable(stream) {
+  assert(IsReadableStream(stream) === true, 'IsReadableStreamLocked should only be used on known readable streams');

Bad assertion message

> @@ -1151,6 +1147,17 @@ function ReadableStreamDefaultControllerHasBackpressure(controller) {
   return true;
 }
 
+// This is used in the implementation of TransformStream.

Comment isn't in sync with the spec, since this is more widely used now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/782#pullrequestreview-60266060