- From: Adam Rice <notifications@github.com>
- Date: Fri, 01 Sep 2017 12:06:45 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 1 September 2017 12:07:13 UTC
Previously if the write() or start() methods of TransformStreamDefaultSink were waiting for backpressure to be relieved when the readable was errored, then they would never complete, meaning that things depending on them such as the promises returned by writer.write() and writer.close() would never resolve either. Set backpressure to false when erroring the TransformStream to permit pending operations to complete. Also add tests for these cases. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/785 -- Commit Summary -- * Permit any pending writes to complete on error -- File Changes -- M reference-implementation/lib/transform-stream.js (6) M reference-implementation/to-upstream-wpts/transform-streams/backpressure.js (62) -- Patch Links -- https://github.com/whatwg/streams/pull/785.patch https://github.com/whatwg/streams/pull/785.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/785
Received on Friday, 1 September 2017 12:07:13 UTC