- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 17 Nov 2017 19:54:55 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 17 November 2017 19:55:18 UTC
So upon reviewing your changes further, I like the removal of special-casing, and the order re-arranging so sizeAlgorithm becomes most-optional. I don't really understand the motivation for splitting; now we'll just be repeating ourselves by setting up state/reader/storedError/disturbed once for readable streams and once for readable byte streams. Similarly I don't quite get the second commit, except for agreeing with the goals of trying to get the controller stuff out of the constructor. Let me try my own take on those... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/857#issuecomment-345349717
Received on Friday, 17 November 2017 19:55:18 UTC