Re: [whatwg/streams] WIP: allow creating streams from specs while using fewer JS objects (#857)

ricea commented on this pull request.



>      1. Set *this*.[[readableStreamController]] to ? Construct(`<a idl>ReadableByteStreamController</a>`, « *this*,
        _underlyingSource_, _highWaterMark_ »).
   1. Otherwise, if _type_ is *undefined*,
     1. If _highWaterMark_ is *undefined*, let _highWaterMark_ be *1*.
-    1. Set *this*.[[readableStreamController]] to ? Construct(`<a idl>ReadableStreamDefaultController</a>`, « *this*,
-       _underlyingSource_, _size_, _highWaterMark_ »).
+    1. Set _highWaterMark_ to ? ValidateAndNormalizeHighWaterMark(_highWaterMark_).
+    1. Let _sizeAlgorithm_ be *undefined*.

Now that sizeAlgorithm is an abstract algorithm and not a concrete function, I don't think there's any point in retaining the optimisation of having undefined mean 1. I have made it default to an algorithm that returns 1 instead.

Implementations may of course retain the optimisation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/857#pullrequestreview-77423763