Re: [whatwg/url] Address several IDNA issues (#309)

rmisev commented on this pull request.



>  
- <li><p>If <var>result</var> is a failure value, return failure.
+ <li><p>If <var>result</var> is failure, then return failure.
 
  <li><p>Set <var>result</var> to the result of running
  <a abstract-op lt=ToUnicode>Unicode ToUnicode</a> with

You missed to specify CheckHyphens, CheckBidi and CheckJoiners for ToUnicode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/309#pullrequestreview-40605338