Re: [whatwg/streams] Refactor writable stream erroring to be centralized (#705)

ricea commented on this pull request.



> @@ -3488,6 +3478,43 @@ WritableStreamDefaultController(<var>stream</var>, <var>underlyingSink</var>, <v
   1. Perform ! WritableStreamDefaultControllerError(*this*, _e_).
 </emu-alg>
 
+<h4 id="ws-default-controller-internal-methods">Writable Stream Default Controller Internal Methods</h4>
+
+The following are additional internal methods implemented by each {{WritableStreamDefaultController}} instance. The
+writable stream implementation will call into these.
+
+<p class="note">The reason these are in method form, instead of as abstract operations, is to make it clear that the
+writable stream implementation is decoupled from the controller implementation, and could in the future be expanded with
+other controllers, as long as those controllers implemented such internal methods. A similar scenario is seen for
+readable streams, where there actually are multiple controller types and as such the counterpart internal methods are
+used polymorphically.
+
+<h5 id="ws-default-controller-private-abort" oldids="writable-stream-default-controller-abort">\[[AbortSteps]]()</h5>

Is it intentional that virtual methods don't have throws/nothrow annotations?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/705#pullrequestreview-29160721

Received on Monday, 27 March 2017 11:40:51 UTC