Re: [whatwg/fetch] Properly set the Origin header for WebSocket requests (#518)

annevk commented on this pull request.

LGTM with nits addressed. I'm guessing we have test coverage for this?

> @@ -3247,7 +3247,8 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
           concept-as-bytes -->
 
  <li><p>If the <i>CORS flag</i> is set or <var>httpRequest</var>'s <a for=request>method</a> is

s/ or/,/

> @@ -3247,7 +3247,8 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
           concept-as-bytes -->
 
  <li><p>If the <i>CORS flag</i> is set or <var>httpRequest</var>'s <a for=request>method</a> is
- neither `<code>GET</code>` nor `<code>HEAD</code>`, then <a for="header list">append</a>
+ neither `<code>GET</code>` nor `<code>HEAD</code>` or <var>httpRequest</var>'s

s/ or/, or/

> @@ -3247,7 +3247,8 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
           concept-as-bytes -->
 
  <li><p>If the <i>CORS flag</i> is set or <var>httpRequest</var>'s <a for=request>method</a> is
- neither `<code>GET</code>` nor `<code>HEAD</code>`, then <a for="header list">append</a>
+ neither `<code>GET</code>` nor `<code>HEAD</code>` or <var>httpRequest</var>'s
+ <a for=request>mode</a> is <code>"websocket"</code>, then <a for="header list">append</a>

Double quotes go on the outside.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/518#pullrequestreview-29160512