Re: [whatwg/streams] Refactor writable stream erroring to be centralized (#705)

ricea commented on this pull request.



>    const abortRequest = stream._pendingAbortRequest;
   stream._pendingAbortRequest = undefined;
   const promise = WritableStreamDefaultControllerAbort(stream._writableStreamController, abortRequest._reason);
   promise.then(
     abortRequest._resolve,
     abortRequest._reject
   );
+  stream._backpressure = false;

I just realised there was something else wrong with the code before you fixed it--it was doing work synchronously after calling into a sink function that might change the WritableStream internal state. It wouldn't necessarily have been a problem, but it's hard to be certain.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/705#discussion_r107875558